Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PathLike[str] type hint for ssl_keyfile #2481

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Add PathLike[str] type hint for ssl_keyfile #2481

merged 3 commits into from
Oct 9, 2024

Conversation

FirelightFlagboy
Copy link
Contributor

Summary

Fix typing for ssl_keyfile field to allow PathLike types like ssl_certfile

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@Kludex Kludex marked this pull request as ready for review October 9, 2024 07:47
@Kludex Kludex changed the title Fix typing for ssl_keyfile field to allow PathLike types Add PathLike[str] type hint for ssl_keyfile Oct 9, 2024
@Kludex
Copy link
Member

Kludex commented Oct 9, 2024

Thanks! 🙏

@Kludex Kludex enabled auto-merge (squash) October 9, 2024 07:50
@Kludex Kludex merged commit 27d976a into encode:master Oct 9, 2024
15 checks passed
@FirelightFlagboy FirelightFlagboy deleted the patch-2 branch October 9, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FirelightFlagboy @Kludex